Fix snapshot initialization stuck issue #16
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a strange bug we noticed. It seems from the example of
raftexample
, the code has 2 bugs:store
)readComments
never exits, since the only condition to exit is onsnap.ErrNoSnapshot
, which will not happen ascommitC <- nil
only happens once while there exists snapshots.This PR fixes this 2 issues by: differentiating initial load (where snapshot is immediately loaded instead of later), and directly return on receiving
nil
fromcommitC
, instead of waiting indefinitely.This fix is not very stable since there might be more strange issues with etcd's Raft API. The offending code is thus highlighted in case we have future issues here.