Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate Chae's .gifs in O-Smart-Pointer/code/ into recitation note O #46

Closed
ohEmily opened this issue Feb 10, 2015 · 3 comments
Closed

Comments

@ohEmily
Copy link
Contributor

ohEmily commented Feb 10, 2015

Right now the gifs are sort of separate. It would be nice if we could reference and include them in the recitation note. Right now many students might not see the .gif or might struggle with understanding the animation.

@kaitlinhuben
Copy link
Contributor

We actually debated this earlier and thought the gifs would be too
distracting directly in the notes, but I can see a case being made for
putting them back.

On Tue, Feb 10, 2015 at 5:16 PM, Emily notifications@github.com wrote:

Right now the gifs are sort of separate. It would be nice if we could
reference and include them in the recitation note. Right now many students
might not see the .gif or might struggle with understanding the animation.


Reply to this email directly or view it on GitHub
#46.

@ohEmily
Copy link
Contributor Author

ohEmily commented Feb 11, 2015

That's a good point. How would you feel about a separate mini note with an
explanation as to what the gifs mean?
On Feb 10, 2015 5:24 PM, "Kaitlin Huben" notifications@github.com wrote:

We actually debated this earlier and thought the gifs would be too
distracting directly in the notes, but I can see a case being made for
putting them back.

On Tue, Feb 10, 2015 at 5:16 PM, Emily notifications@github.com wrote:

Right now the gifs are sort of separate. It would be nice if we could
reference and include them in the recitation note. Right now many
students
might not see the .gif or might struggle with understanding the
animation.


Reply to this email directly or view it on GitHub
#46.


Reply to this email directly or view it on GitHub
#46 (comment).

@kaitlinhuben
Copy link
Contributor

SGTM

Kaitlin Huben
kaitlin.huben@gmail.com

On Tue, Feb 10, 2015 at 11:42 PM, Emily notifications@github.com wrote:

That's a good point. How would you feel about a separate mini note with an
explanation as to what the gifs mean?
On Feb 10, 2015 5:24 PM, "Kaitlin Huben" notifications@github.com wrote:

We actually debated this earlier and thought the gifs would be too
distracting directly in the notes, but I can see a case being made for
putting them back.

On Tue, Feb 10, 2015 at 5:16 PM, Emily notifications@github.com wrote:

Right now the gifs are sort of separate. It would be nice if we could
reference and include them in the recitation note. Right now many
students
might not see the .gif or might struggle with understanding the
animation.


Reply to this email directly or view it on GitHub
#46.


Reply to this email directly or view it on GitHub
#46 (comment).


Reply to this email directly or view it on GitHub
#46 (comment).

cjubb39 added a commit that referenced this issue Sep 14, 2015
explain the smartptr animations.  close #46.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants