Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a if_unmodified_since condition to InitiateFileUploadRequest #178

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Add a if_unmodified_since condition to InitiateFileUploadRequest #178

merged 1 commit into from
Aug 18, 2022

Conversation

aduffeck
Copy link
Contributor

This change adds an optional if_unmodified_since field to InitiateFileUploadRequest which allows for conditional uploads based on the mtime.

@aduffeck aduffeck requested a review from labkode as a code owner August 16, 2022 14:11
glpatcern
glpatcern approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, even more generic than the if_not_exists flag: I guess the intended scope for this new flag is to implement/enforce it on the sync clients, where eventually the if_not_exists flag should also be enforced.

@glpatcern glpatcern merged commit a9392fb into cs3org:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@glpatcern glpatcern glpatcern approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aduffeck @butonic @glpatcern