add delete home to the storage provider

[C0rby]

Added a delete home method to the storage provider to be able to clean up when removing a user.

[labkode]

This API call should be part of an Admin API, we have discussed it in the past and now with this need arising is the right moment to create it. @C0rby can you add this new API here: cs3/admin/v1beta1/admin_api.proto with that method?
Note that the method must accept a user ID as argument, this API will be used by site administrators or by robot accounts to automate actions.

[C0rby]

Cool.
Just for clarification, should I move the method to the admin_api or copy it to have it in both places?

[refs]

This API call should be part of an Admin API, we have discussed it in the past and now with this need arising is the right moment to create it. @C0rby can you add this new API here: cs3/admin/v1beta1/admin_api.proto with that method?
Note that the method must accept a user ID as argument, this API will be used by site administrators or by robot accounts to automate actions.

thanks for the clarification, I meant userid, not an entire user 👯

[labkode]

@C0rby I've added some comments, overall looks pretty good.

[labkode]

@C0rby @refs any update on this? Will be nice to merge it in.

[C0rby]

I rebased the branch.
From my POV we can merge, right @butonic?

[kulmann]

@C0rby could you rebase please? Would be nice to get this in. :-)

[phil-davis]

@C0rby are you online this week? Can you rebase this and we can try to push it along. There are things that depend on this that are waiting.

[phil-davis]

@labkode @butonic @refs looks like time to review.

There is no response from drone CI - but that will be related to the drone troubles over Christmas...

[C0rby]

Well, new year new luck.

Can we merge this? @refs, @butonic, @labkode

[refs]

@C0rby it LGTM, could we get @ishank011 to have another pair of eyes? :)

[ishank011]

@C0rby looks good but how will ProvisionStorage be called? I'm guessing from the ProvisionUser method in the admin API? How will we supply the quota parameters to it then?

[C0rby]

I see your point.
@butonic, what do you say? Add the quota to the ProvisionUser api?

[butonic]

As discussed at the CS3 we should pick a more generic name for CreateHome. @ishank011 proposed CreateStorageSpace which captures the difference between creating a storage vs creating something inside a storage. Something being called a space.

Other options were CreateTree, CreateSpace, CreateSubTree, and CreateRoot but they are either too abstract / graph theory influenced (anything with tree or root) or would invent a new term (space).

Storage space seems to be a good middle ground. Furthermore it can be used not only for user homes but also other spaces eg. project or group spaces.

The method needs an owner (which can be a user or a group), optionally quota and opaque data as usual.

cc @ishank011 @C0rby

[C0rby]

@jfd, wouldn't CreateStorageSpace also need a path parameter or something like that?

[butonic]

CreateStorageSpace where?

In the gateway? there it would need an indication of which storage should create the space. might be done by path or by storageid.

In a storage provider? No, It is up to the storage provider to determine where to put the new root of the storeage.

In the storage registry? Yes, it needs to know where to mount a storage space. Not only a strorage provitder. But this is a bigger change.

For now, I would limit this change to the StorageProvider Api in the context of the UserProvisioning api: the Gateway can determine the responsible storage provider by calling storageregistry->GetHome() and then using a storageregistry->GetProvider(<home>). It can then send the CreateStorageSpace(<owner>, <quota>) to it, just as it is currently sending a CreateHome()

[butonic]

@C0rby While you are at it could you also add an UpdateStorageSpace so we can adjust the quota? We need that for the quota related tests.

[butonic]

blocks owncloud/ocis#1290
blocks owncloud/ocis#1313
blocks owncloud/product#247

[C0rby]

@ishank011 @labkode, @butonic and I now implemented the storage API how we think it should be.
I removed the admin API again and only added the storage space stuff.

[phil-davis]

@C0rby is there a PR to cs3org/reva that implements this?

[C0rby]

@phil-davis, not yet. We still have to do that. It will most likely happen within the coming sprint.