Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix etag propagation in ocis driver #1264

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Oct 21, 2020

We now use a new synctime timestamp instead of trying to read the mtime to avoid race conditions when the stat request happens too quickly.

fixes owncloud/product#249

@butonic butonic requested a review from labkode as a code owner October 21, 2020 11:33
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
Copy link
Contributor Author

butonic commented Oct 21, 2020

Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@phil-davis
Copy link
Contributor

Note: we do not see test scenarios starting to pass here, because the core ownCloud10 API tests are only running with OWNCLOUD storage.
They also run with OCIS storage in owncloud/ocis repo - so tests should start passing there, after this code is applied.

I do plan to run the core ownCloud10 API tests with OCIS storage here in cs3org/reva - I just haven't sorted it out yet.

@ishank011 ishank011 merged commit 8ff108f into cs3org:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

etag propagation API tests are intermittent
4 participants