Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use safer defaults for TLS verification on LDAP connections #2053

Merged
merged 4 commits into from Sep 16, 2021

Commits on Sep 14, 2021

  1. Use safer defaults for TLS verification on LDAP connections

    The LDAP client connections were hardcoded to ignore certificate validation
    errors everywhere. This commit changes that to uses a secure default,
    which can be overridden by the new config parameter 'insecure'.
    Also the LDAP related test configs are updated to set that override for
    the tests.
    rhafer committed Sep 14, 2021
    Copy the full SHA
    344b7e0 View commit details
    Browse the repository at this point in the history
  2. Add utility module for LDAP connections

    This should reduce code duplication a bit. Currently this only handles the
    initial setup of the LDAP connection (e.g. the TLS parameters). Could be
    enhanced to also handle the initial authentication in the future.
    rhafer committed Sep 14, 2021
    Copy the full SHA
    1a45d4e View commit details
    Browse the repository at this point in the history
  3. Allow to add trusted certificates for LDAP

    This add a new configparameter "cacert" to allow to add trusted CAs
    and Server Certificates for the LDAP connections. This allows us to
    avoid using "insecure" when running against self-signed certificates.
    (As e.g. issued for glauth by default)
    rhafer committed Sep 14, 2021
    Copy the full SHA
    9659cfd View commit details
    Browse the repository at this point in the history
  4. Add Changelog

    rhafer committed Sep 14, 2021
    Copy the full SHA
    ee401dd View commit details
    Browse the repository at this point in the history