Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share jail fixes #2864

Merged
merged 4 commits into from
May 13, 2022
Merged

Share jail fixes #2864

merged 4 commits into from
May 13, 2022

Conversation

micbar
Copy link
Member

@micbar micbar commented May 12, 2022

Bugfix: Fix Grant Space IDs

The opaqueID for a grant space was incorrectly overwritten with the root space id.

@micbar micbar requested review from a team, labkode, ishank011 and glpatcern as code owners May 12, 2022 16:20
@micbar micbar changed the title Share jail and ocdav fixes Share jail fixes May 12, 2022
@micbar micbar force-pushed the share-jail-id branch 2 times, most recently from b87af35 to 1fe7f2d Compare May 12, 2022 16:26
@micbar micbar requested review from butonic and C0rby May 12, 2022 16:26
@micbar micbar force-pushed the share-jail-id branch 6 times, most recently from 1d16c9f to 0a5d221 Compare May 13, 2022 08:32
@sonarcloud
Copy link

sonarcloud bot commented May 13, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 258 Code Smells

No Coverage information No Coverage information
7.1% 7.1% Duplication

Makefile Show resolved Hide resolved
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@butonic butonic merged commit ea26f07 into cs3org:edge May 13, 2022
@butonic butonic deleted the share-jail-id branch May 13, 2022 12:37
@micbar micbar mentioned this pull request May 25, 2022
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants