Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework file deletion #2868

Merged
merged 6 commits into from
May 18, 2022
Merged

Rework file deletion #2868

merged 6 commits into from
May 18, 2022

Conversation

kobergj
Copy link
Contributor

@kobergj kobergj commented May 13, 2022

@kobergj
move all children to bin when trashing
8373a7d 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
revert trashing logic but use it when purging
c112c59 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
changelog
82b7489 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
remove empty parent folders when purging nodes
192c3ff 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
Merge branch 'edge' into ReworkFileDeletion
2abecaf
@kobergj kobergj mentioned this pull request May 16, 2022
Closed
9 tasks
@kobergj kobergj marked this pull request as ready for review May 16, 2022 09:51
@kobergj kobergj requested review from a team, labkode, ishank011 and glpatcern as code owners May 16, 2022 09:51
butonic
butonic requested changes May 17, 2022
View reviewed changes
pkg/storage/utils/decomposedfs/recycle.go Outdated Show resolved Hide resolved
pkg/storage/utils/decomposedfs/tree/tree.go Outdated Show resolved Hide resolved
pkg/storage/utils/decomposedfs/tree/tree.go Show resolved Hide resolved
@kobergj
delete revisions also
1947a90 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@sonarcloud
Copy link

sonarcloud bot commented May 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@butonic butonic merged commit 493a942 into cs3org:edge May 18, 2022
@kobergj kobergj deleted the ReworkFileDeletion branch May 19, 2022 07:36
@butonic butonic mentioned this pull request May 19, 2022
Closed
@micbar micbar mentioned this pull request May 25, 2022
Closed
25 tasks
@kobergj kobergj mentioned this pull request Oct 14, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 20, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 28, 2022
Merged
@kobergj kobergj mentioned this pull request Dec 19, 2022
Merged
@kobergj kobergj mentioned this pull request May 22, 2023
Closed
@kobergj kobergj mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@wkloucek wkloucek Awaiting requested review from wkloucek

@rhafer rhafer Awaiting requested review from rhafer

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@ishank011 ishank011 Awaiting requested review from ishank011

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kobergj @butonic