Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix meta requests with no ID #2899

Merged
merged 1 commit into from
May 30, 2022
Merged

fix meta requests with no ID #2899

merged 1 commit into from
May 30, 2022

Conversation

micbar
Copy link
Member

@micbar micbar commented May 27, 2022

Description

Bugfix for owncloud/ocis#3879

@micbar micbar requested review from a team, labkode, ishank011 and glpatcern as code owners May 27, 2022 13:56
@micbar micbar mentioned this pull request May 27, 2022
Closed
@micbar micbar force-pushed the fix-meta branch 2 times, most recently from 154a5fd to e1599ae Compare May 28, 2022 12:09
@micbar micbar marked this pull request as draft May 28, 2022 12:14
@micbar micbar marked this pull request as ready for review May 28, 2022 12:20
@sonarcloud
Copy link

sonarcloud bot commented May 29, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 266 Code Smells

No Coverage information No Coverage information
7.3% 7.3% Duplication

@micbar
Copy link
Member Author

micbar commented May 29, 2022

@kobergj @butonic I tried to handle it in the existing method, was cleaner to write a new handler func. More duplication but cleaner.

kobergj
kobergj approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me. A little copying is better than a little dependency 😄

@micbar micbar merged commit fd9e2af into cs3org:edge May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@ishank011 ishank011 Awaiting requested review from ishank011

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

@dragotin dragotin Awaiting requested review from dragotin

@phil-davis phil-davis Awaiting requested review from phil-davis

@butonic butonic Awaiting requested review from butonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@micbar @kobergj