Leverage shares space storageid and type when listing shares #2975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
requested review from
labkode,
ishank011,
glpatcern and
a team
as code owners
butonic
changed the title
butonic
commented
Jun 15, 2022
| @@ -200,7 +200,7 @@ func (c *cachedRegistryClient) ListStorageProviders(ctx context.Context, in *reg | |||
| return resp, nil | |||
| case storageID == "": | |||
| return resp, nil | |||
| case storageID == utils.ShareStorageProviderID: | |||
| case storageID == utils.ShareStorageProviderID: // TODO do we need to compare providerid and spaceid separately? | |||
There was a problem hiding this comment.
I could not make the debugger halt here, but AFACT we need to skip the cache when the spaceid or the providerid match the sharesstorageproviderid. In and case the CI was green without this, so ... can be deferred to a subsequent PR.
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
… type Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
leverage-sharesstorage-storageid
branch
from
4ca796b
to
063d4da
Compare
rhafer
approved these changes
Jun 16, 2022
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Merged
40 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list shares call now also fills the storageid to allow the space registry to directly route requests to the correct storageprovider. The spaces registry will now also skip storageproviders that are not configured for a requested type, causing type 'personal' requests to skip the sharestorageprovider.
related #2881