Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sharing validators and comparisons #3022

Merged
merged 2 commits into from Jun 30, 2022
Merged

Improve sharing validators and comparisons #3022

merged 2 commits into from Jun 30, 2022

Conversation

micbar
Copy link
Member

@micbar micbar commented Jun 30, 2022

Description

Prerequisite for #2967

@micbar micbar requested review from a team, labkode, ishank011 and glpatcern as code owners June 30, 2022 12:12
@micbar micbar requested review from butonic and kobergj June 30, 2022 12:13
@butonic
Copy link
Contributor

butonic commented Jun 30, 2022

#nice

https://drone.cernbox.cern.ch/cs3org/reva/7746/13/6

runsh: Total unexpected passed scenarios throughout the test run:
4768 | apiShareCreateSpecialToShares2/createShareWithInvalidPermissions.feature:26
4769 | apiShareCreateSpecialToShares2/createShareWithInvalidPermissions.feature:27
4770 | apiShareCreateSpecialToShares2/createShareWithInvalidPermissions.feature:28
4771 | apiShareCreateSpecialToShares2/createShareWithInvalidPermissions.feature:29
4772 | apiShareManagementBasicToShares/createShareToSharesFolder.feature:117
4773 | apiShareManagementBasicToShares/createShareToSharesFolder.feature:118
4774 | apiShareManagementBasicToShares/createShareToSharesFolder.feature:132
4775 | apiShareManagementBasicToShares/createShareToSharesFolder.feature:133

https://drone.cernbox.cern.ch/cs3org/reva/7746/15/6

runsh: Total unexpected passed scenarios throughout the test run:
2921 | apiShareUpdateToShares/updateShare.feature:113
2922 | apiShareUpdateToShares/updateShare.feature:114

@micbar micbar merged commit 17db1ce into cs3org:edge Jun 30, 2022
@micbar micbar mentioned this pull request Jul 19, 2022
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@kobergj kobergj kobergj approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@ishank011 ishank011 Awaiting requested review from ishank011

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@micbar @butonic @kobergj