prevent cross space move #3035
Merged
prevent cross space move #3035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
C0rby
approved these changes
Jul 6, 2022
micbar
approved these changes
Jul 6, 2022
|
Maybe you should implement the move as "copy/remove" rather than forbidden this feature? |
Yes. COPY & DELETE works fine |
|
@labkode the move is only forbidden for decomposedfs. It is technically possible, but requires moving all children, from one space to another, which is why I decided to forbid it for now. Other drivers are not affected. |
kobergj
pushed a commit
that referenced
this pull request
Jul 7, 2022
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
kobergj
pushed a commit
to kobergj/reva
that referenced
this pull request
Jul 11, 2022
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
kobergj
added a commit
to kobergj/reva
that referenced
this pull request
Jul 14, 2022
This reverts commit 6cd5041.
36 tasks
9 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decomposedfs now prevents moving across space boundaries
fixes owncloud/ocis#4114