gateway: use go-micro store to cache #3250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
butonic
force-pushed
the
micro-cache-store
branch
2 times, most recently
from
7435358
to
14e8d58
Compare
butonic
commented
Sep 19, 2022
butonic
force-pushed
the
micro-cache-store
branch
from
14e8d58
to
400bfdf
Compare
butonic
force-pushed
the
micro-cache-store
branch
from
866adff
to
a9064f7
Compare
butonic
requested review from
labkode,
ishank011,
glpatcern and
a team
as code owners
This was referenced Sep 21, 2022
aduffeck
requested changes
Sep 22, 2022
aduffeck
approved these changes
Sep 22, 2022
butonic
force-pushed
the
micro-cache-store
branch
2 times, most recently
from
0f2c78c
to
17181b9
Compare
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
73 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the in memory caches of the gateway with the go-micro store interface. It allows sharing the cache using redis or etcd for redundant deployments and the correct timing of stat cache invalidation because the dataprovider can now invalidate the cache when the upload has finished.
first step for owncloud/ocis#4427