Fix public link lookup performance #3866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
requested review from
labkode,
ishank011,
glpatcern and
a team
as code owners
|
cc @fschade this fixes public link access performance |
butonic
force-pushed
the
space-registry-path-filtering
branch
4 times, most recently
from
7b2810c
to
e3d91e8
Compare
aduffeck
approved these changes
May 22, 2023
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
aduffeck
force-pushed
the
space-registry-path-filtering
branch
from
e3d91e8
to
e821214
Compare
aduffeck
force-pushed
the
space-registry-path-filtering
branch
from
b0f5016
to
fdd867c
Compare
butonic
commented
May 25, 2023
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix inefficient path based space lookup for public links.
public links use
/public/{token}path based references. This PR checks the configured mountpoint of a space to skip storage providers that don't have a matching mountpoint, when looking up spaces for a path.