Allow passing of external trace provider to reva. #4019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the passing of an external trace provider to reva, bypassing the built in tracing initialisation. This makes it possible for services that embed reva to use their own provider instead of having reva initialise its own.
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
butonic
reviewed
Jun 29, 2023
As discussed on zoom; my autoformatter formats octal that way for clarity. https://github.com/mvdan/gofumpt |
butonic
approved these changes
Jun 29, 2023
This was referenced Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the passing of an external trace provider to reva, bypassing
the built in tracing initialisation. This makes it possible
for services that embed reva to use their own provider instead of
having reva initialise its own.