Allow listing received Shares by service accounts #4244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobergj
requested review from
labkode,
ishank011,
glpatcern and
a team
as code owners
kobergj
changed the title
kobergj
force-pushed
the
ListReceivedSharesByServiceAccounts
branch
2 times, most recently
from
8bedfcd
to
8f830c3
Compare
Signed-off-by: jkoberg <jkoberg@owncloud.com>
kobergj
force-pushed
the
ListReceivedSharesByServiceAccounts
branch
from
8f830c3
to
9dc752b
Compare
aduffeck
approved these changes
Oct 11, 2023
pkg/share/manager/memory/memory.go
Outdated
| var rss []*collaboration.ReceivedShare | ||
| m.lock.Lock() | ||
| defer m.lock.Unlock() | ||
| user := ctxpkg.ContextMustGetUser(ctx) | ||
| if user.GetId().GetType() == userv1beta1.UserType_USER_TYPE_SERVICE { | ||
| // TODO: gateway missing! | ||
| // u, err := utils.GetUser(forUser, nil) |
There was a problem hiding this comment.
Do you think the commented code is helpful? I think I would rather leave it out, it's not that hard to figure it out when actually doing the refactoring.
7 tasks
Signed-off-by: jkoberg <jkoberg@owncloud.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows listing received shares by service account users