Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing ng preparation and bugfix #4335

Merged
merged 3 commits into from Nov 14, 2023
Merged

Conversation

micbar
Copy link
Member

@micbar micbar commented Nov 13, 2023

Description

  1. Fix bug for ocis sharing "EnableExpiredSharesCleanup" config.
  2. Add helper function to check sufficient CS3ResourcePermissions

Usage

@rhafer @fschade

I think we can use that helper function to calculate the available permissions.

Please let me know if you see a more elegant way without reflection 馃槃

Copy link

update-docs bot commented Nov 13, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar micbar changed the title Sharing ng links Sharing ng preparation and bugfix Nov 13, 2023
@micbar micbar marked this pull request as ready for review November 13, 2023 19:33
@micbar micbar requested review from labkode, glpatcern and a team as code owners November 13, 2023 19:33
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy path looks good to me, i just found one case with a potential panic.

pkg/conversions/role.go Show resolved Hide resolved
pkg/conversions/role_test.go Show resolved Hide resolved
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT 馃殌

@micbar micbar merged commit 7f1549f into cs3org:edge Nov 14, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants