Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nats-js-kv store #4363

Merged
merged 3 commits into from Dec 12, 2023
Merged

Add nats-js-kv store #4363

merged 3 commits into from Dec 12, 2023

Conversation

kobergj
Copy link
Contributor

@kobergj kobergj commented Nov 27, 2023

Adds a new store type nats-js-kv. See respective go-micro PR for details: go-micro/plugins#132

Also fixes a panic when an error occurs during locking

Copy link

update-docs bot commented Nov 27, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj kobergj changed the title Fix panic when locking files Add nats-js-kv store Dec 7, 2023
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj kobergj marked this pull request as ready for review December 7, 2023 15:12
@kobergj kobergj requested review from a team, labkode and glpatcern as code owners December 7, 2023 15:12
go.mod Show resolved Hide resolved
Copy link
Contributor

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the go version bump requires touching more places and AFAICT there is a todo?

Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj kobergj requested a review from butonic December 12, 2023 13:46
@butonic butonic merged commit 5efdfa4 into cs3org:edge Dec 12, 2023
9 checks passed
@kobergj kobergj deleted the FixLockPanic branch March 13, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants