Bugfix: Fix CS3 status code when looking up non existing share #4366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhafer
force-pushed
the
getShareNotFound
branch
from
c3cb6c0
to
08c6a19
Compare
When trying to lookup a share that does not exist we now return a proper "not found" error instead of just an "internal error.
rhafer
force-pushed
the
getShareNotFound
branch
from
08c6a19
to
988d83e
Compare
dragonchaser
approved these changes
Nov 27, 2023
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Nov 29, 2023
rhafer
added a commit
to owncloud/ocis
that referenced
this pull request
Nov 30, 2023
2403905
pushed a commit
to 2403905/ocis
that referenced
this pull request
Dec 4, 2023
2403905
pushed a commit
to 2403905/ocis
that referenced
this pull request
Dec 8, 2023
12 tasks
2403905
pushed a commit
to 2403905/ocis
that referenced
this pull request
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to lookup a share that does not exist we now return a proper "not found" error instead of just an "internal error.