Fix truncating existing files #4448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
butonic
approved these changes
Jan 8, 2024
The TUS handler will not finish the upload for us, that's usually already done in the TUS POST request already, which we bypass by doing the InitiateFileUpload flow.
aduffeck
force-pushed
the
fix-truncating-existing-files
branch
from
843e74d
to
717c1c6
Compare
butonic
reviewed
Jan 10, 2024
.drone.star
Outdated
| @@ -5,7 +5,7 @@ OSIXIA_OPEN_LDAP = "osixia/openldap:1.3.0" | |||
| REDIS = "redis:6-alpine" | |||
| OC_CI_PHP = "cs3org/behat:latest" | |||
| OC_LITMUS = "owncloud/litmus:latest" | |||
| OC_CS3_API_VALIDATOR = "owncloud/cs3api-validator:0.2.0" | |||
| OC_CS3_API_VALIDATOR = "owncloud/cs3api-validator:latest" | |||
There was a problem hiding this comment.
shouldn't we stick to a release?
butonic
reviewed
Jan 10, 2024
butonic
reviewed
Jan 10, 2024
| @@ -284,47 +286,6 @@ var _ = Describe("File uploads", func() { | |||
| }) | |||
| }) | |||
|
|
|||
| When("the user uploads a zero byte file", func() { | |||
There was a problem hiding this comment.
should we add a negative test to document the clients should know they are not supposed to send a subsequent request after initiating a 0 byte file upload?
butonic
approved these changes
Jan 10, 2024
Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de>
aduffeck
force-pushed
the
fix-truncating-existing-files
branch
2 times, most recently
from
928fef9
to
8b626a3
Compare
aduffeck
force-pushed
the
fix-truncating-existing-files
branch
from
8b626a3
to
51cb2d7
Compare
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem where existing files kept their content when being overwritten by a 0-byte file.
Fixes owncloud/ocis#8003