Add filename incrementor for secret filedrops. #4491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonchaser
force-pushed
the
filename-incrementor
branch
4 times, most recently
from
5744f5a
to
4b087c2
Compare
dragonchaser
requested review from
labkode,
a team and
glpatcern
as code owners
kobergj
requested changes
Feb 1, 2024
|
@micbar we implemented this in ocdav ... I'm not sure if this needs to move to the storage provider. It would need to have a way to find out if the request is made to a public file drop. In ocdav we use the token stat permission set to make that decision. Which feels fragile, but that is what we can determine. Hm we might check the share permissions in dav.go and store them in the context ... then tus.go and dav.go can read the share info 🤔 |
Co-authored-by: Jörn Dreyer <jfd@butonic.de> Signed-off-by: Christian Richter <crichter@owncloud.com>
Co-authored-by: Jörn Dreyer <jfd@butonic.de> Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de> Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
dragonchaser
force-pushed
the
filename-incrementor
branch
from
9fc7110
to
b961119
Compare
butonic
reviewed
Feb 2, 2024
butonic
reviewed
Feb 2, 2024
butonic
reviewed
Feb 2, 2024
|
I created a followup issue owncloud/ocis#8358. This PR is good as it is for now. |
butonic
approved these changes
Feb 2, 2024
kobergj
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: Add filename incrementor for secret filedrops
We have added a function that appends a number to the filename if the file already exists in a secret filedrop.
This is useful if you want to upload a file with the same name multiple times.
refs owncloud/ocis#8291