fix(sharesstorageprovider): Merge shares of the same resourceid #4517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhafer
force-pushed
the
ocisissue/8080
branch
from
d66690e
to
74ce1c7
Compare
rhafer
force-pushed
the
ocisissue/8080
branch
from
74ce1c7
to
5f4fa06
Compare
rhafer
force-pushed
the
ocisissue/8080
branch
from
5f4fa06
to
f92ad50
Compare
|
Example: We now only return a single The old response was 5 times the same item: |
The fetchShares call is already stat'ing the resource a few lines above. If that didn't return and info, why should it do here?
When listing the sharejail root, merge shares that target the same resource into a single resource. In order to avoid the resourceId changing randomly the id will be composed from the oldest accepted share that exist for the resource. Ideally we'd compose the resourceId based on the id of the shared resource, but that is currently not possible in a backwards compatible way. Some clients seem to rely on the fact that the resource ids in the sharejail contain valid shareids. Fixes: owncloud/ocis#8080
rhafer
force-pushed
the
ocisissue/8080
branch
from
f92ad50
to
62cb6cd
Compare
butonic
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When listing the sharejail root, merge shares that target the same resource into a single resource. In order to avoid the resourceId changing randomly the id will be composed from the oldest accepted share that exist for the resource.
Ideally we'd compose the resourceId based on the id of the shared resource, but that is currently not possible in a backwards compatible way. Some clients seem to rely on the fact that the resource ids in the sharejail contain valid shareids.
Fixes: owncloud/ocis#8080