Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor decomposedfs to be more extensible, e.g. for the posix driver #4581

Merged
merged 8 commits into from
May 2, 2024

Conversation

aduffeck
Copy link
Contributor

No description provided.

Copy link

update-docs bot commented Mar 18, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@aduffeck aduffeck force-pushed the more-extensible-decomposedfs branch 6 times, most recently from deb3012 to 9886b24 Compare March 18, 2024 14:19
@aduffeck aduffeck force-pushed the more-extensible-decomposedfs branch from 9886b24 to 5892b45 Compare April 22, 2024 09:17
@aduffeck aduffeck marked this pull request as ready for review April 22, 2024 10:07
@aduffeck aduffeck requested review from a team, labkode and glpatcern as code owners April 22, 2024 10:07
@butonic
Copy link
Contributor

butonic commented Apr 22, 2024

I see where you are deleting the metadata lock ... is that conflicting with the old xattr backend? I fear that would delete the actual metadata file. 🤔 👀

no ... the xattr backend also has a dedicated file for metadata locks

Copy link
Contributor

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when deleting my storage users I don't seem to be able to get a personal space:

2024-04-22T15:18:49+02:00 ERR error when calling Createhome error="gateway: grpc failed with code CODE_INTERNAL" line=/home/jfd/Repositories/ocis/services/proxy/pkg/middleware/create_home.go:78 service=proxy
2024-04-22T15:18:49+02:00 ERR failed to list storage spaces error="error reading user index: stat /home/jfd/.ocis/storage/users/indexes/by-user-id/534bb038-6f9d-4093-946f-133be61fa4e7.mpk: no such file or directory" filters=[{"Term":{"SpaceType":"project"},"type":4},{"Term":{"User":{"idp":"https://cloud.ocis.test","opaque_id":"534bb038-6f9d-4093-946f-133be61fa4e7"}},"type":6}] line=/home/jfd/Repositories/reva/internal/grpc/services/storageprovider/storageprovider.go:575 pkg=rgrpc service=storage-users status={"code":15,"message":"error listing spaces","trace":"b32ff7051e1b71f97dd10c798b02d094"} traceid=b32ff7051e1b71f97dd10c798b02d094

@aduffeck
Copy link
Contributor Author

@butonic Ah, ocis is still configuring the UserLayout variable for decomposedfs based fses, so reusing that variable for the posixfs use case was a bad idea.
I now introduced PersonalSpacePathTemplate and GeneralSpacePathTemplate instead, the ocis part (which isn't required for now since for ocis/s3ng it just default to "" as required anyway)) is part of owncloud/ocis#8598

@butonic
Copy link
Contributor

butonic commented Apr 23, 2024

ok, this works for me as well. But lets make sure the ocis CI does not choke: owncloud/ocis#8935

@butonic
Copy link
Contributor

butonic commented Apr 23, 2024

I hope this is just flaky, rerunning ci

@aduffeck aduffeck mentioned this pull request May 2, 2024
@aduffeck
Copy link
Contributor Author

aduffeck commented May 2, 2024

@butonic the merge is green at owncloud/ocis#9038 now. Good to go?

@butonic butonic merged commit 9e15bce into cs3org:edge May 2, 2024
9 checks passed
@butonic
Copy link
Contributor

butonic commented May 2, 2024

@aduffeck do you bump reva in ocis?

@aduffeck aduffeck deleted the more-extensible-decomposedfs branch May 2, 2024 14:51
@aduffeck
Copy link
Contributor Author

aduffeck commented May 2, 2024

Sure thing: owncloud/ocis#9050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants