fix: permission check in public share update #4622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found one more corner case 🙈 |
micbar
force-pushed
the
fix-publicshareupdate
branch
from
484e469
to
e9dd5f1
Compare
|
ready for review. |
2403905
approved these changes
Apr 10, 2024
rhafer
approved these changes
Apr 10, 2024
I am on it. We can also wait for them. |
|
Hm, @butonic The publicsharemanager is currently not testable, it creates its own gatewaySelector. We would need to refactor that to make it testable. |
Cool 🎉 . I am fine to merge this as is and have another PR for the unit test. |
Fine. I need to refactor the New() Method which creates a lot of noise. So i would merge that now here, backport to stable and then refactor it on |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We fixed the permission check for updating public shares. When updating the permissions of a public share while not providing a password, the check must be against the new permissions to take into account that users can opt out only for view permissions.
relates to https://github.com/owncloud/enterprise/issues/6558