Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test async processing cornercases #4625

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Apr 11, 2024

We added tests to cover several bugs where file metadata or parent treesize might get corrupted when postprocessing errors occur in specific order.
For now, the added test cases test the current behavior but contain comments and FIXMEs for the expected behavior.

The PR adds eight new test cases:

  • the first can succeed before the second succeeds - Works!
  • the first can succeed after the second succeeds - Works!
  • the first can succeed before the second fails - Works!
  • the first can succeed after the second fails - the file should still be in "processing" after second upload is deleted
  • the first can fail before the second succeeds - list of revisions should be 0
  • the first can fail after the second succeeds - list of revisions should be 0
  • the first can fail before the second fails - file should be deleted, size should be correctly reverted
  • the first can fail after the second fails - file should be deleted, size should be correctly reverted

I'd like to get this in so it does not get lost in an spreadsheet on my desktop.

@aduffeck And I are entertaining the idea of creating the note on the initiateFile call and keep track of all ongoing uploads in the node metadata. It will allow resolving the correct size diff and processing status. Will create an issue to track that.

Copy link

update-docs bot commented Apr 11, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic force-pushed the test-async-processing-cornercases branch from e290be8 to b1f87cb Compare April 11, 2024 14:44
@butonic butonic marked this pull request as ready for review April 11, 2024 14:45
@butonic butonic requested a review from a team as a code owner April 11, 2024 14:45
@butonic butonic force-pushed the test-async-processing-cornercases branch from b1f87cb to a52b961 Compare April 11, 2024 15:03
@butonic butonic force-pushed the test-async-processing-cornercases branch from a52b961 to 358c94f Compare April 11, 2024 15:17
@butonic butonic force-pushed the test-async-processing-cornercases branch from 358c94f to 9dfd2e8 Compare April 12, 2024 09:48
Copy link
Contributor

@aduffeck aduffeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the test-async-processing-cornercases branch from 9dfd2e8 to 5c437c8 Compare April 12, 2024 10:12
@butonic butonic merged commit 5465b3a into cs3org:edge Apr 12, 2024
9 checks passed
@butonic butonic deleted the test-async-processing-cornercases branch April 12, 2024 10:53
@micbar micbar mentioned this pull request Jun 19, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants