Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement for TokenInfo endpoint #4653

Merged
merged 1 commit into from
May 14, 2024
Merged

Replacement for TokenInfo endpoint #4653

merged 1 commit into from
May 14, 2024

Conversation

2403905
Copy link

@2403905 2403905 commented Apr 23, 2024

Related issue owncloud/ocis#8858

Copy link

update-docs bot commented Apr 23, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@2403905 2403905 force-pushed the issue-8858 branch 3 times, most recently from b42a20c to b000896 Compare April 25, 2024 10:57
@2403905 2403905 force-pushed the issue-8858 branch 4 times, most recently from 5428b05 to 13e7ed5 Compare May 2, 2024 15:54
@2403905 2403905 marked this pull request as ready for review May 2, 2024 15:59
@2403905 2403905 requested review from labkode, a team and glpatcern as code owners May 2, 2024 15:59
@2403905 2403905 force-pushed the issue-8858 branch 2 times, most recently from 9211141 to a3fc79f Compare May 7, 2024 13:35
@2403905 2403905 changed the title POC Replacement for TokenInfo endpoint Replacement for TokenInfo endpoint May 7, 2024
// Build new context without an authenticated user for the public link
baseURI := ctx.Value(net.CtxKeyBaseURI).(string)
logger := appctx.GetLogger(ctx)
span := trace.SpanFromContext(ctx)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@butonic What do you think about copying the trace context this way?

Copy link
Contributor

@rhafer rhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the few cosmetic comments, I think this is ok.

changelog/unreleased/tokenInfo-endpoint-replacement.md Outdated Show resolved Hide resolved
changelog/unreleased/tokenInfo-endpoint-replacement.md Outdated Show resolved Hide resolved
changelog/unreleased/tokenInfo-endpoint-replacement.md Outdated Show resolved Hide resolved
internal/http/services/owncloud/ocdav/dav.go Outdated Show resolved Hide resolved
internal/http/services/owncloud/ocdav/dav.go Outdated Show resolved Hide resolved
@2403905 2403905 merged commit 7099ed4 into cs3org:edge May 14, 2024
9 checks passed
@micbar micbar mentioned this pull request Jun 19, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants