Support t and x in ACEs #4685
Merged
Support t and x in ACEs #4685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhafer
previously requested changes
May 15, 2024
butonic
force-pushed
the
support-tx-in-aces
branch
3 times, most recently
from
a82261e
to
6675dd2
Compare
butonic
commented
May 15, 2024
butonic
commented
May 15, 2024
butonic
force-pushed
the
support-tx-in-aces
branch
from
6675dd2
to
327b901
Compare
Closed
14 tasks
butonic
force-pushed
the
support-tx-in-aces
branch
from
327b901
to
8c18051
Compare
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
May 16, 2024
|
Created owncloud/ocis#9188 to check this with ocis full-ci |
butonic
force-pushed
the
support-tx-in-aces
branch
from
8c18051
to
0aac08d
Compare
butonic
force-pushed
the
support-tx-in-aces
branch
from
0aac08d
to
74c9441
Compare
butonic
pushed a commit
to rhafer/ocis
that referenced
this pull request
May 16, 2024
Fixes: owncloud#9128 Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
pushed a commit
to rhafer/ocis
that referenced
this pull request
May 16, 2024
Fixes: owncloud#9128 Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
May 16, 2024
Fixes: owncloud#9128 Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
rhafer
force-pushed
the
support-tx-in-aces
branch
from
d7469b7
to
ed3e99d
Compare
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
May 16, 2024
Fixes: owncloud#9128 Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
|
@butonic I've now introduced the new role "UploaderOnly". This is needed by ocs to be able to create filedrop links. I am still pondering if it might be better to keep the "Uploader" roles as it was before and introduce a new role instead for the "Upload/Download/Edit without Delete" thing that is supposed to be provided for user shares. |
rhafer
force-pushed
the
support-tx-in-aces
branch
from
ed3e99d
to
57743c6
Compare
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
May 21, 2024
Fixes: owncloud#9128 Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
The "uploader" role is really meant to be an upload-only role. It is use e.g. to assemble the permissions for a "secret-file-drop" public link. To reflect the needs for the Uploader user-sharing role, which is allowed to upload/download but not delete, we now introduce the "editor-lite" role.
rhafer
force-pushed
the
support-tx-in-aces
branch
from
57743c6
to
916ef34
Compare
kobergj
requested changes
May 21, 2024
Co-authored-by: kobergj <juliankoberg@googlemail.com>
kobergj
approved these changes
May 21, 2024
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
May 21, 2024
To get: cs3org/reva#4685 Fixes: owncloud#9128 Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
May 21, 2024
To get: cs3org/reva#4685 Fixes: owncloud#9128 Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
added a commit
to owncloud/ocis
that referenced
this pull request
May 21, 2024
[full-ci] Bump reva for: cs3org/reva#4685
ownclouders
pushed a commit
to owncloud/ocis
that referenced
this pull request
May 21, 2024
[full-ci] Bump reva for: cs3org/reva#4685
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support view only shares (dowload forbidden) we added t (read attrs) and x (directory traversal) permissions to the decomposed FS ACEs.
The change is backwards compatible. an ACE with
rpermission will still grant Stat, getPath, InitiateFileDownload and ListContainer permissions. Newly written grants will explicitly settandxpermissions. If we need to be more strict, we could increase the version byte tox02(x01was used in the very early days) which can than unparse therto only grant the InitiateFileDownload permission.