Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/login page #2

Merged
merged 7 commits into from
Feb 24, 2018
Merged

Feature/login page #2

merged 7 commits into from
Feb 24, 2018

Conversation

cobalt293
Copy link
Collaborator

I reorganized the Angular project a bit and added in the url-router. If you go to /login it will take you to the login page.

This is hollow until we setup user models but I wanted to work through each major page.

@cobalt293 cobalt293 added the enhancement New feature or request label Feb 16, 2018
@redemma71
Copy link
Collaborator

hey, @andrewoconnell89.

this looks good, though it isn't previewing for me. webpack compiles fine, but i'm seeing some errors in the console.

also, when i did an "npm install" to load the new dependencies you added, i saw this:

<ccover|project-angular-src>npm install
project-angular-src@0.0.0 /Users/ccover/Documents/my_documents/BU/CS673/project/project-angular-src
├── @angular/animations@5.2.5
├── @angular/cdk@5.2.1
├── UNMET PEER DEPENDENCY @angular/core@5.2.2
├── @angular/material@5.2.1
└── hammerjs@2.0.8

npm WARN @angular/animations@5.2.5 requires a peer of @angular/core@5.2.5 but none was installed.

I revised the package.json file & ran "npm install" a few more times until I got no error messages.
I pushed my changes to a branch called features/login-page-cdcFeedback. all you really need to do is diff your package.json & the one on this branch. i think you had core set to 5.2.0, and animation set to 5.2.5, so there was a dependency issue on my end.

even so, i am not seeing anything when I browse to "http://localhost:4200". what does your page look like?

a little more work, but it seems like this is close. you put a heck of a lot of work into this. great work!

chad

@redemma71
Copy link
Collaborator

@andrewoconnell89.

here is a screencap of my browser & the error messages:

screen shot 2018-02-19 at 1 00 51 pm

@redemma71
Copy link
Collaborator

@andrewoconnell89

this might be promising: webpack/webpack-dev-server#416

Copy link
Collaborator

@redemma71 redemma71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm getting console errors. left a bunch of info for you. will be out most of the day, but will check back later. feels like this is really close to working.

@cobalt293
Copy link
Collaborator Author

wow i just learned a ton about node package requirements. I ended up downgrading angular down from 5.2.5 to 5.2.2 and typescript to 2.6.2 in addition i added ajv to the express project.

After making those changes I was able to npm install both projects with no warning/errors

I also cleaned up the routes in the angular project so it will default route to login. Sorry i didn't clarify to go to /login

@cobalt293 cobalt293 merged commit 48f346d into master Feb 24, 2018
@cobalt293 cobalt293 deleted the feature/login-page branch February 24, 2018 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants