Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds further steps sections to readme #12

Merged
merged 6 commits into from
Jan 6, 2021
Merged

Adds further steps sections to readme #12

merged 6 commits into from
Jan 6, 2021

Conversation

csalmeida
Copy link
Owner

Adds a further steps section to the README for users following the installation path using the generator.
The same steps are displayed in the generator at the end of the install.

@csalmeida csalmeida requested a review from arrontp January 2, 2021 11:43
@csalmeida csalmeida self-assigned this Jan 2, 2021
arrontp
arrontp reviewed Jan 4, 2021
View reviewed changes
Copy link
Collaborator

@arrontp arrontp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few minor changes (see comments).
It may be worth copying this to Generator docs too for consistency.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@csalmeida csalmeida requested a review from arrontp January 5, 2021 10:15
arrontp
arrontp reviewed Jan 5, 2021
View reviewed changes
Copy link
Collaborator

@arrontp arrontp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All docs updated.
Could you double check these minor updates to docs?

csalmeida
csalmeida commented Jan 6, 2021
View reviewed changes
Copy link
Owner Author

@csalmeida csalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions! LGTM

@arrontp arrontp merged commit 4a5756a into main Jan 6, 2021
@csalmeida csalmeida deleted the further-instructions branch January 6, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arrontp arrontp arrontp left review comments

Assignees

@csalmeida csalmeida

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csalmeida @arrontp