Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Csandman/fix menu placement #18

Merged
merged 5 commits into from
Nov 18, 2021
Merged

Csandman/fix menu placement #18

merged 5 commits into from
Nov 18, 2021

Conversation

csandman
Copy link
Owner

@csandman csandman commented Nov 18, 2021 •
edited
Loading

  • Fix type exports for native react-select types
  • Fix a link for one of the icons in the README
  • Fix the eslint jsx allowed extensions
  • Fix the menuPlacement prop that is native to react-select

Closes #17

@csandman csandman linked an issue Nov 18, 2021 that may be closed by this pull request
[BUG] menuPlacement prop isn't working #17
Closed
@csandman csandman merged commit 8833b84 into main Nov 18, 2021
@csandman csandman deleted the csandman/fix-menu-placement branch November 18, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahallibone jonahallibone jonahallibone approved these changes

Assignees

@jonahallibone jonahallibone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] menuPlacement prop isn't working
2 participants
@csandman @jonahallibone