You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The myTkSimpleDialog.py module was copied from the TkSimpleDialog.py module a long time ago and modified to put the OK and Cancel buttons in the correct places depending on the platform. It was an easy way to create dialogs that request strings and numbers. But the instances feature exposed another modification that is needed: these dialogs are not associated with the window from which they were launched; they are always associated with the main window. This not only makes the dialog pop up in an unexpected place but also brings the main window to the front and puts the focus on it. On Windows, if the main window is minimized, the dialog comes up minimized too, which is more than confusing. Furthermore, this module generates a large number of pylint errors and warnings.
The myTkSimpleDialog.py module should be retired. The IV_Swinger2_gui.py module already has a base Dialog class. It will be pretty simple to create the needed dialogs and functions to replace those from myTkSimpleDialog.py and to fix the issue mentioned above.
The text was updated successfully, but these errors were encountered:
This commit removes the myTkSimpleDialog.py module and replaces it with internal classes and functions. These dialogs now require the specification of the master window that the dialog is associated with.
The myTkSimpleDialog.py module was copied from the TkSimpleDialog.py module a long time ago and modified to put the OK and Cancel buttons in the correct places depending on the platform. It was an easy way to create dialogs that request strings and numbers. But the instances feature exposed another modification that is needed: these dialogs are not associated with the window from which they were launched; they are always associated with the main window. This not only makes the dialog pop up in an unexpected place but also brings the main window to the front and puts the focus on it. On Windows, if the main window is minimized, the dialog comes up minimized too, which is more than confusing. Furthermore, this module generates a large number of pylint errors and warnings.
The myTkSimpleDialog.py module should be retired. The IV_Swinger2_gui.py module already has a base Dialog class. It will be pretty simple to create the needed dialogs and functions to replace those from myTkSimpleDialog.py and to fix the issue mentioned above.
The text was updated successfully, but these errors were encountered: