Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPP values should be logged #59

Closed
csatt opened this issue May 17, 2019 · 1 comment
Closed

MPP values should be logged #59

csatt opened this issue May 17, 2019 · 1 comment
Assignees
@csatt
Labels
enhancement

Comments

@csatt
Copy link
Owner

csatt commented May 17, 2019

The calculated power, voltage, and current of the maximum power point (MPP) are displayed on the graph, but are not captured anywhere else.

This information was captured in the log file for IV Swinger 1, but the code where this was done was specific to IV Swinger 1, so that logging was lost. It should be added to the IV Swinger 2 code.

There are two reasons this is useful:

  • The MPP values can be extracted by a script
  • The logged MPP values include more significant digits than on the graph
@csatt csatt self-assigned this May 17, 2019
csatt added a commit that referenced this issue May 17, 2019
@csatt
Add MPP logging (Issue #59)
0c56b36 
Added logging of the following values at the calculated MPP:

  - Amps
  - Volts
  - Ohms
  - Watts

The log message is in the same format as the MPP log message for IV Swinger 1. All values have 6 digits after the decimal point, but that should not imply that there is that much precision in the measurements or MPP calculation.
@csatt csatt closed this as completed May 17, 2019
@csatt csatt mentioned this issue Nov 23, 2019
Closed
@csatt csatt reopened this Jun 27, 2020
@csatt
Copy link
Owner Author

csatt commented Jun 27, 2020

This change needs to be modified so that the logging is conditional on there being a logger. This allows the IV_Swinger2_plotter class to be used without creating a logger, e.g. for standalone cases where logging is not needed.

csatt added a commit that referenced this issue Jun 27, 2020
@csatt
Fix re-open of Issue #59
a70778b 
Suppress MPP logging if there is no logger.
@csatt csatt closed this as completed Jun 27, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csatt csatt

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@csatt