Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac exception on quitting application #99

Closed
csatt opened this issue Dec 10, 2019 · 1 comment
Closed

Mac exception on quitting application #99

csatt opened this issue Dec 10, 2019 · 1 comment
Assignees
Labels

Comments

@csatt
Copy link
Owner

csatt commented Dec 10, 2019

Mac only:

If the application is quit using one of the following:
IV Swinger 2 menu -> Quit IV Swinger 2
Command Q
Right-click -> Quit on dock icon
an editor window with something like the following comes up:

Unexpected error: <type 'exceptions.SystemExit'>
Traceback (most recent call last):
File "IV_Swinger2_gui.py", line 8480, in main
File "IV_Swinger2_gui.py", line 1836, in run
File "lib-tk/Tkinter.py", line 1125, in mainloop
File "lib-tk/Tkinter.py", line 218, in _exit
SystemExit: 0


Please copy/paste the above and send it to csatt1@gmail.com

Alternately, you may attach this file:
/var/folders/yj/k_91_km93gb2w8t_pcbgyyth0000gn/T/tmpob5lBk

This does NOT happen when the application is closed by clicking on the red close button in the upper right corner.

It is harmless but should be fixed.

@csatt csatt added the bug label Dec 10, 2019
@csatt csatt self-assigned this Dec 10, 2019
csatt added a commit that referenced this issue Dec 10, 2019
Catch SystemExit exception, which occurs on Mac when application is quit with IV Swinger 2 menu "Quit IV Swinger 2" entry, command-Q, or right-click on dock icon.
csatt added a commit that referenced this issue Dec 11, 2019
The previous commit was not complete. When the Mac application is quit, the close_gui() method was not getting called to clean up and close out the log file properly. Now it is.
@csatt
Copy link
Owner Author

csatt commented Dec 11, 2019

NOTE: I "cheated" and updated the Mac .dmg with the fix in release 2.5.2 to avoid having to do another whole release just for this bug. Since the code change is at the very end of IV_Swinger2_gui.py, the line numbers for any exception in this file will still be correct.

@csatt csatt closed this as completed Dec 11, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant