Added Devise::LdapAdapter.valid_login? method #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 4, 2011 18:34
|
And also, I'm much obliged for the quick merges of my other two requests. I think they're valuable changes that don't break compatibility at least according to the tests. Keeps me from having to actively maintain my fork. Thanks! |
added 2 commits
October 5, 2011 15:03
Conflicts: test/rails_app/test/unit/user_test.rb
cschiewek
added a commit
that referenced
this pull request
Oct 5, 2011
Added Devise::LdapAdapter.valid_login? method
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method determines whether a login is found in an LDAP search. See new tests for sample usage:
I didn't mean to include the updated schema.rb, but I accidentally mangled my master branch. The tests still all pass with the new schema and reflects Devise 1.4's new way of using (i.e., not) the salt. The exception is the known issue in #49, which I'm not going to attempt to fix because I can't figure out the original purpose behind the missing file.
If you want me to figure out how to only pull request the two files and leave out schema.rb, I can; just let me know, but I haven't been successful so far.