This repository has been archived by the owner on Feb 25, 2022. It is now read-only.
Add pkg:go_router_builder #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is working on my side |
awesome! |
kevmoo
commented
Dec 5, 2021
| path: 'details/:details', | ||
| factory: $PersonDetailsRouteExtension._fromState, | ||
| ) | ||
| ]) |
There was a problem hiding this comment.
missed a trailing comma in my hand-written bits!
kevmoo
commented
Dec 5, 2021
| '/family/${Uri.encodeComponent(fid)}' | ||
| '/person/${Uri.encodeComponent(pid.toString())}' | ||
| '/details/${Uri.encodeComponent(_$PersonDetailsEnumMap[details]!)}', | ||
| '/family/${Uri.encodeComponent(fid)}/person/${Uri.encodeComponent(pid.toString())}/details/${Uri.encodeComponent(_$PersonDetailsEnumMap[details]!)}', |
There was a problem hiding this comment.
Need to see if there is a smart way to force wrapper on these long ones
kevmoo
commented
Dec 5, 2021
| void go(BuildContext buildContext) => buildContext.go(location); | ||
| } | ||
|
|
||
| const _$PersonDetailsEnumMap = { |
kevmoo
commented
Dec 5, 2021
| @@ -66,7 +66,7 @@ class App extends StatelessWidget { | |||
| RouteDef<PersonRoute>( | |||
| path: 'person/:pid', | |||
| children: [ | |||
| RouteDef(path: 'details/:details'), | |||
| RouteDef<PersonDetailsRoute>(path: 'details/:details'), | |||
There was a problem hiding this comment.
Oops! Generator caught this – not me!
kevmoo
changed the title
Closes #66 Migrated the existing named_routes example to the builder Updated the related example data model to use int and enum
Will make it easier to support other types later
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #66
Migrated the existing named_routes example to the builder
Updated the related example data model to use int and enum