Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To choose desired behaviour, a developer should be able to configure the default TALES expression type #279

Closed
craigfowler opened this issue Dec 12, 2020 · 0 comments
Closed

To choose desired behaviour, a developer should be able to configure the default TALES expression type #279

craigfowler opened this issue Dec 12, 2020 · 0 comments
Labels
enhancement An improvement, new feature or other addition to the project
Milestone
v2.0.0

Comments

@craigfowler
Copy link
Member

Currently, the default TALES expression type is hard-coded to path expressions.

I would like this to become a configuration option upon the RenderingConfig class. If left unset it should still default to path, but it will enable developers to choose a different default if they wish.

The property should be a string, accepting any expression name.
@craigfowler craigfowler added the enhancement An improvement, new feature or other addition to the project label Dec 12, 2020
@craigfowler craigfowler added this to the v2.0.0 milestone Dec 12, 2020
@craigfowler craigfowler mentioned this issue Dec 13, 2020
Closed
craigfowler added a commit that referenced this issue Dec 21, 2020
@craigfowler
WIP #279 - Add failing test case for new functionality
8caa7f5 
This also removes the hard-coding against the 'path' expression type.
It also removes some accidentally-duplicated string identifiers.  They
had been copied into two similar classes of well-known identifiers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement An improvement, new feature or other addition to the project
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@craigfowler