Tidied up the options form, fixed tabstops and made it localizable #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e alert. It was triggering the alert after uncheck (even when it was empty).
Adding pt (Portuguese) + fix add check whether textbox is empty befor…
This was referenced Dec 12, 2017
csharpfritz
added a commit
that referenced
this pull request
Dec 12, 2017
* Completed #7 - Build music starts and stops properly * Added attribution for modem carrier sound * Added modem carrier sound * First cut at OptionPage * Completed initial 'during build music' features in #5 * Set version number to 0.2 * Refactored to be able to unit test * Introduced ?. operator to make code cleaner as suggested in #10 * Defined new fields for our manifest * Completed refactoring to unit tests that verify the OptionsPage * Tidied up the options form, fixed tabstops and made it localizable (#18) * Tidied up the options form, fixed tabstops and made it localizable * Adding pt (Portuguese) + fix add check whether textbox is empty before alert. It was triggering the alert after uncheck (even when it was empty). * Increased row height to better fit the font-size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ian Barker (checkdigits) changes to GeneralOptionsUserControl form