Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Heroku support #141

Closed
kkdai opened this issue Aug 17, 2022 · 6 comments
Closed

Create Heroku support #141

kkdai opened this issue Aug 17, 2022 · 6 comments

Comments

@kkdai
Copy link
Contributor

kkdai commented Aug 17, 2022

Hi
I love your contribution, and it would be great if this tool could be easy to host on Heroku.
Thank you

@cshum
Copy link
Owner

cshum commented Aug 17, 2022

Hi @kkdai thanks for you suggestion.

I am familiar with Heroku hosting, but I assume the deployment steps would be pretty standard across Docker images?

Imagor is stateless (except File System config), should work out of box by running the Docker image with minimal config.

Is there anything specific steps can be added for Heroku? A pull request for Heroku deployment template or documentations, would be very welcomed.

@kkdai
Copy link
Contributor Author

kkdai commented Aug 17, 2022

Yes, sure. The PR is ready to send after I confirm with you the design for "-imagor-unsafe" flag.
It seems the "-imagor-unsafe" default is off(make it more strict), but it will fail on Heroku run.
Which is equal to docker run -p 8000:8000 shumc/imagor.
What is your suggestion for this?

@cshum
Copy link
Owner

cshum commented Aug 17, 2022

Does heroku run supports environment variables configuration? All configuration flags have their environment variable equivalent, for example:

# both are equivalent

/usr/local/bin/imagor -imagor-unsafe -imagor-secret 1234

IMAGOR_UNSAFE=1 IMAGOR_SECRET=1234 /usr/local/bin/imagor

https://github.com/cshum/imagor#configuration

@kkdai
Copy link
Contributor Author

kkdai commented Aug 18, 2022

Thank you for the suggestion.

cshum added a commit that referenced this issue Aug 18, 2022
* Add support for Heroku

* Update README.md

Co-authored-by: Adrian Shum <adrian@cshum.com>
@cshum
Copy link
Owner

cshum commented Aug 18, 2022

Thanks for the pull request!

@kkdai
Copy link
Contributor Author

kkdai commented Aug 18, 2022

Closed by #142, thank you.

@kkdai kkdai closed this as completed Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants