Skip to content

Commit

Permalink
Insert missing `break's.
Browse files Browse the repository at this point in the history
Out of the box, the Eclipse Indigo CDT complains about missing break
statements.  This commit adds breaks to avoid most of those warnings.
  • Loading branch information
eeide committed Jun 25, 2011
1 parent 25075ea commit 4345387
Show file tree
Hide file tree
Showing 9 changed files with 17 additions and 7 deletions.
1 change: 1 addition & 0 deletions src/AbsRndNumGenerator.cpp
Expand Up @@ -81,6 +81,7 @@ AbsRndNumGenerator::make_rndnum_generator(RNDNUM_GENERATOR impl, const unsigned
break;
default:
assert(!"unknown random generator");
break;
}

return rImpl;
Expand Down
2 changes: 1 addition & 1 deletion src/CrestExtension.cpp
Expand Up @@ -65,7 +65,7 @@ CrestExtension::type_to_string(const Type *t)
case eUInt: return "unsigned_int";
case eLong: return "int";
case eULong: return "unsigned_int";
default: assert(0);
default: assert(0); break;
}
assert(0);
return "";
Expand Down
3 changes: 3 additions & 0 deletions src/DeltaMonitor.cpp
Expand Up @@ -76,6 +76,7 @@ DeltaMonitor::GetSequence()
break;
default:
assert("DeltaMonitor GetSequence error" && 0);
break;
}
assert(DeltaMonitor::seq_);
return DeltaMonitor::seq_;
Expand All @@ -97,6 +98,7 @@ DeltaMonitor::CreateRndNumInstance(const unsigned long seed)
break;
default:
assert("DeltaMonitor CreateRndNumInstance error" && 0);
break;
}
}

Expand Down Expand Up @@ -168,6 +170,7 @@ DeltaMonitor::OutputStatistics(ostream &out)
break;
default:
assert(0);
break;
}
}

Expand Down
1 change: 1 addition & 0 deletions src/DepthSpec.cpp
Expand Up @@ -424,6 +424,7 @@ int DepthSpec::depth_guard_by_type(enum dType ty, int extra_flag)
DEPTH_GUARD_CASE(dtSafeOpFlags, extra_flag)
default:
assert(0);
break;
}

return GOOD_DEPTH;
Expand Down
1 change: 1 addition & 0 deletions src/FunctionInvocationBinary.cpp
Expand Up @@ -197,6 +197,7 @@ FunctionInvocationBinary::get_type(void) const
switch (eFunc) {
default:
assert(!"invalid operator in FunctionInvocationBinary::get_type()");
break;

case eAdd:
case eSub:
Expand Down
1 change: 1 addition & 0 deletions src/FunctionInvocationUnary.cpp
Expand Up @@ -124,6 +124,7 @@ FunctionInvocationUnary::get_type(void) const
switch (eFunc) {
default:
assert(!"invalid operator in FunctionInvocationUnary::get_type()");
break;

case ePlus:
case eMinus:
Expand Down
9 changes: 5 additions & 4 deletions src/SafeOpFlags.cpp
Expand Up @@ -81,7 +81,7 @@ SafeOpFlags::flags_to_type(bool sign, enum SafeOpSize size)
case sInt16: return eShort;
case sInt32: return eInt;
case sInt64: return eLongLong;
default: assert(0);
default: assert(0); break;
}
}
else {
Expand All @@ -90,7 +90,7 @@ SafeOpFlags::flags_to_type(bool sign, enum SafeOpSize size)
case sInt16: return eUShort;
case sInt32: return eUInt;
case sInt64: return eULongLong;
default: assert(0);
default: assert(0); break;
}
}
assert(0);
Expand Down Expand Up @@ -174,6 +174,7 @@ SafeOpFlags::OutputSize(std::ostream &out) const
break;
default:
assert(!"invalid size!");
break;
}
}

Expand Down Expand Up @@ -221,7 +222,7 @@ SafeOpFlags::to_string(enum eBinaryOps op) const
case eDiv: s = "safe_div_"; break;
case eLShift: s = "safe_lshift_"; break;
case eRShift: s = "safe_rshift_"; break;
default: ;
default: break;
}
ostringstream oss;
OutputFuncOrMacro(oss);
Expand All @@ -239,7 +240,7 @@ SafeOpFlags::to_string(enum eUnaryOps op) const
string s;
switch (op) {
case eMinus: s = "safe_unary_minus_"; break;
default: ;
default: break;
}
ostringstream oss;
OutputFuncOrMacro(oss);
Expand Down
5 changes: 3 additions & 2 deletions src/StatementAssign.cpp
Expand Up @@ -545,7 +545,8 @@ StatementAssign::OutputAsExpr(std::ostream &out) const
break;

default:
assert (false);
assert(false);
break;
}
} else {
OutputSimple(out);
Expand All @@ -559,4 +560,4 @@ StatementAssign::OutputAsExpr(std::ostream &out) const
// tab-width: 4
// End:

// End of file.
// End of file.
1 change: 1 addition & 0 deletions src/Type.cpp
Expand Up @@ -765,6 +765,7 @@ Type::get_bitfield_length(int length_flag)
break;
default:
assert(0);
break;
}
return length;
}
Expand Down

0 comments on commit 4345387

Please sign in to comment.