Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Section Function Attribute and Alias Function Attribute #82

Merged

Conversation

shubhamnarlawar77
Copy link
Contributor

The pull request(done under guidance of Martin Liska @marxin) generates section function attribute.

@jxyang - Please review and suggest changes

@shubhamnarlawar77 shubhamnarlawar77 changed the title Added support for Section Function Attribute Added support for Section Function Attribute and Alias Function Attribute Sep 29, 2019
@shubhamnarlawar77
Copy link
Contributor Author

I have added patch for Alias Function Attribute as well. The patch creates alias for function name during generation phase while it checks command line and rnd_flipcoin() to select original function name or alias during output phase.

@jxyang - Please review and suggest changes

@shubhamnarlawar77
Copy link
Contributor Author

I have added noclone and optimize attributes as well. These are the function attributes I want to merge in master. Later, I will send pull request for type attributes and vector extensions. @jxyang - please check it

@jxyang
Copy link
Member

jxyang commented Oct 8, 2019

I will take a look this weekend.

src/Function.cpp Show resolved Hide resolved
src/Function.cpp Show resolved Hide resolved
src/Function.cpp Show resolved Hide resolved
src/Function.cpp Outdated Show resolved Hide resolved
@jxyang
Copy link
Member

jxyang commented Jan 6, 2020

@shubhamnarlawar77 Have you resolved all the requested changes? If so, please mark the ones as resolved.

@shubhamnarlawar77
Copy link
Contributor Author

@shubhamnarlawar77 Have you resolved all the requested changes? If so, please mark the ones as resolved.

Done. I have resolved below mentioned changes -

  1. Alias name of a function is as random as function name generated.
  2. OutputForwardDeclAlias() is used to output alias function declaration.
  3. Rewrite InitializeAttributesChoices() with static intializers. It would be appropriate to do it at the end of function attribute as you have updated the script.

Is this pull request fine to you now? or do you want me to include static initializers of attributes in this pull request?

@shubhamnarlawar77
Copy link
Contributor Author

@shubhamnarlawar77 Have you resolved all the requested changes? If so, please mark the ones as resolved.

The last suggested change i.e. initializing function attributes with string initializers is also included in this pull request. The pull request if fine to go. Please check it @jxyang

@jxyang jxyang merged commit 9797ed2 into csmith-project:master Jan 9, 2020
@jxyang
Copy link
Member

jxyang commented Jan 9, 2020

Thanks for the contribution! @shubhamnarlawar77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants