-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R-3.4.0 works #124
R-3.4.0 works #124
Conversation
I tried R-3.4.0, and it seems that everything works OK so far.
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
=======================================
Coverage 43.56% 43.56%
=======================================
Files 13 13
Lines 2043 2043
=======================================
Hits 890 890
Misses 1153 1153 Continue to review full report at Codecov.
|
Kamil, it works indeed. But since we are preparing this package for the upcoming Bioconductor release, there is the need of developing against R-devel for this cycle. One workaround would be to clone the repo, change the line in the |
Thanks for the comment! I had a hunch it was due to Bioconductor. Just out of curiosity, I wonder if you could help me understand. Is it true that you could simultaneously use R-3.5 in your development environment AND keep the text Does Bioconductor require that you set the DESCRIPTION file to 3.5? The instructions at the Bioconductor website aren't clear to me. I guess I'm confused about the requirements for matching Bioconductor versions and R versions. |
As far as I can remember, it is not required but rather recommended. I think it is even one thing that gets checked via |
Federico pretty much covered it all: we are aware that the package seems to run successfully on R-3.4. However, we have focused our efforts entirely on the next Bioconductor release, which isn't that far. Note that that branch will become obsolete at the next Bioconductor release, as R 3.5 will become available as a stable R release. |
I'm closing this PR as we won't merge it to
|
I tried R-3.4.0, and it seems that everything works OK so far.
At some institutions, it's not easy to update to the latest R version. I think many users will appreciate the ability to install this package on R-3.4.