Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for sfont on Android #1813

Merged
merged 3 commits into from
Jan 28, 2024
Merged

fixes for sfont on Android #1813

merged 3 commits into from
Jan 28, 2024

Conversation

vlazzarini
Copy link
Member

This PR contains the changes to soundfont opcodes to enable them to work correctly on Android (#1783), originally made to csound6 and now incorporated to the 7.0 code.

Opcodes/sfont.c Outdated Show resolved Hide resolved
Opcodes/sfont.c Outdated Show resolved Hide resolved
Opcodes/sfont.c Outdated Show resolved Hide resolved
Opcodes/sfont.h Outdated Show resolved Hide resolved
@tjingboem
Copy link
Member

If i am understanding correctly, is iskip taken out again?
I was enjoying this tied note option, and would wish this option will be available for all other opcodes as well...

i did an inventory regarding the missing iskip option a few months ago: #1736

@vlazzarini
Copy link
Member Author

no changes to iskip

@vlazzarini
Copy link
Member Author

I missed a couple of updates in develop but now it should be in line with it.

Opcodes/sfont.c Outdated Show resolved Hide resolved
@kunstmusik
Copy link
Member

Looks good to me, merging.

@kunstmusik kunstmusik merged commit 457dd1b into develop Jan 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants