Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kairos-crypto - split trait and introduce no_std support #123

Merged
merged 9 commits into from
Jun 17, 2024

Conversation

koxu1996
Copy link
Contributor

@koxu1996 koxu1996 commented Jun 13, 2024

This PR moves feature-gated parts of trait CryptoSigner into separate traits:

Additionally no_std support is introduced - 4684d4f.

Closes #86.

@koxu1996 koxu1996 self-assigned this Jun 13, 2024
@koxu1996 koxu1996 marked this pull request as ready for review June 13, 2024 12:21
@koxu1996
Copy link
Contributor Author

I confirmed it works for environments without std:

rustup target add thumbv7m-none-eabi
cargo build -p kairos-crypto --no-default-features --features crypto-casper --target thumbv7m-none-eabi

@koxu1996 koxu1996 force-pushed the feature/kairos-crypto-improvements branch from f9ea42d to 43d3357 Compare June 14, 2024 12:47
Copy link
Contributor

@Avi-D-coder Avi-D-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love the extension trait with a single impl, but approved.

@marijanp marijanp merged commit 3c8ab4f into main Jun 17, 2024
4 checks passed
@marijanp marijanp deleted the feature/kairos-crypto-improvements branch June 17, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move feature gated parts of CryptoSigner trait
3 participants