refactor: use the same variable functions definition everywhere

cssnano · Jun 7, 2022 · 858a8b7 · 858a8b7
1 parent e707fc2
commit 858a8b7
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 3 deletions.
diff --git a/packages/postcss-normalize-positions/src/index.js b/packages/postcss-normalize-positions/src/index.js
@@ -13,7 +13,7 @@ const verticalValue = new Map([
   ['top', '0'],
 ]);
 const mathFunctions = new Set(['calc', 'min', 'max', 'clamp']);
-
+const variableFunctions = new Set(['var', 'env', 'constant']);
 /**
  * @param {valueParser.Node} node
  * @return {boolean}
@@ -31,7 +31,7 @@ function isVariableFunctionNode(node) {
     return false;
   }
 
-  return ['var', 'env'].includes(node.value.toLowerCase());
+  return variableFunctions.has(node.value.toLowerCase());
 }
 
 /**

diff --git a/packages/postcss-normalize-positions/test/index.js b/packages/postcss-normalize-positions/test/index.js
@@ -230,6 +230,11 @@ test(
   passthroughCSS('background-position: env(--foo)')
 );
 
+test(
+  'should pass through with constant',
+  passthroughCSS('background-position: constant(--foo)')
+);
+
 test(
   'should normalize when property in uppercase',
   processCSS('BACKGROUND-POSITION: center', 'BACKGROUND-POSITION: 50%')

diff --git a/packages/postcss-normalize-repeat-style/src/index.js b/packages/postcss-normalize-repeat-style/src/index.js
@@ -21,6 +21,7 @@ function isCommaNode(node) {
   return node.type === 'div' && node.value === ',';
 }
 
+const variableFunctions = new Set(['var', 'env', 'constant']);
 /**
  * @param {valueParser.Node} node
  * @return {boolean}
@@ -30,7 +31,7 @@ function isVariableFunctionNode(node) {
     return false;
   }
 
-  return ['var', 'env'].includes(node.value.toLowerCase());
+  return variableFunctions.has(node.value.toLowerCase());
 }
 
 /**

diff --git a/packages/postcss-normalize-repeat-style/test/index.js b/packages/postcss-normalize-repeat-style/test/index.js
@@ -105,6 +105,11 @@ test(
   passthroughCSS('background-position: env(--foo)')
 );
 
+test(
+  'should pass through with constant',
+  passthroughCSS('background-position: constant(--foo)')
+);
+
 test(
   'should normalize background position with var and multiple background',
   processCSS(