-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #1402 , fix #1216 #1403
fix #1402 , fix #1216 #1403
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1403 +/- ##
=======================================
Coverage 97.61% 97.61%
=======================================
Files 122 122
Lines 9992 9993 +1
=======================================
+ Hits 9754 9755 +1
Misses 238 238
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! It's rare that someone is able to submit a working PR to cssnano. I agree that the code is wonky, but if we deactivated a plugin for that reason we would deactivate most of cssnano. Have you ever looked into swc or Parcel CSS? It looks like they've made a lot of progress building a CSS minifier from scratch, but I don't know if they're less buggy than the current JavaScript CSS minifiers.
You're welcome :)
True, that is the tradeoff with a tool that minifies to equivalent but not equal CSS. Thank you for reviewing and merging this so quickly 🎉 |
Now correctly de-dupes selector lists.
This minification still feels a bit wonky to me.
Doesn't have sufficient test coverage and it relies on an implementation detail of
postcss-selector-parser
.I would personally remove it to prevent bugs.