Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:matches() was renamed to :is() #43

Merged
merged 3 commits into from
Apr 3, 2019
Merged

:matches() was renamed to :is() #43

merged 3 commits into from
Apr 3, 2019

Conversation

petamoriken
Copy link
Contributor

The CSS Working Group just discussed Rename :matches() to :is(), and agreed to the following:

  • RESOLVED: Rename :matches() to :is() and deprecate :matches() in Safari and anywhere else using it

w3c/csswg-drafts#3258 (comment)

@jonathantneal
Copy link
Collaborator

Excellent. The ID needs to be renamed to is-pseudo-class.

@petamoriken
Copy link
Contributor Author

@jonathantneal Done 😄

@ExE-Boss
Copy link

When is this getting merged?

@jonathantneal
Copy link
Collaborator

This is further complicated now, but it’s not your fault. The caniuse data is going to be misleading because it refers to :matches and the PostCSS plugin needs to be pulled because it implements the wrong version of matches. See: postcss/postcss-selector-matches#16

@jonathantneal
Copy link
Collaborator

I’m going to change :matches to stage of -1, then add is separately. If you want to make the change, I’ll merge it from this PR. Otherwise, I’ll make a separate PR and close this.

Copy link

@ExE-Boss ExE-Boss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r+

@ExE-Boss
Copy link

ExE-Boss commented Apr 3, 2019

review?(@jonathantneal): You might want to squash and merge this.

Copy link

@ExE-Boss ExE-Boss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to sort this alphabetically, so that is-pseudo-class is after in-out-of-range-pseudo-class, but before lab-function.

@jonathantneal jonathantneal merged commit 1f69e61 into csstools:master Apr 3, 2019
@petamoriken petamoriken deleted the update/matches_to_is branch April 3, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants