-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated PostCSS, and added warning when variable cannot be resolved along with option to turn warning on or off ('warnOfUnresolved'). Upped version. Etc. #37
Conversation
…along with option to turn warning on or off ('warnOfUnresolved'). Upped version.
… and updated documentation. This is my first pass.
…w css test file for testing the variables as function option.
Hi @jonathantneal |
Seems a little complex. Transparent |
There is a lot going on in this PR. My thoughts are:
Actually, I stopped maintaining precss almost immediately after it was released, going as far as to not follow the project. I am just now seeing how many issues it has and how popular it remains despite that — which makes no sense to me. This is a lot to take in. |
@deemstone Yes, passing @jonathantneal I agree. It is a lot. There are a few extras but 95% of it was mandatory to accomplish adding warnings via postcss 6's new API, or were directly the results of upgrading to postcss 6. The other 5% are things myself and my team really wanted to see (e.g. warnings on unresolved variables). With this larger commit merged in future PRs can be much smaller to add some new features and fixes. But this larger PR seems unavoidable to get postcss-advanced-variables upgrade to postcss 6. How can I help get this merged and help maintain postcss-advanced-variables? I don't have the time to help with precss, but I can help with this postcss-advanced-variables if you want. |
Thanks @jonathantneal . Now that it is merged in, can it be published to NPM? |
…long with option to turn warning on or off ('warnOfUnresolved'). Upped version. Etc. (#37) * v2.0.0 * Updated PostCSS, and added warning when variable can not be resolved along with option to turn warning on or off ('warnOfUnresolved'). Upped version. * Reverted most eslintrc settings back. * Added yarn.lock * Work on adding function option for variables option. Added unit test, and updated documentation. This is my first pass. * Reordered arguments of getVariableTransformedString, and added the new css test file for testing the variables as function option. * Updated test to test the second argument of the variables function option.
…long with option to turn warning on or off ('warnOfUnresolved'). Upped version. Etc. (#37) * v2.0.0 * Updated PostCSS, and added warning when variable can not be resolved along with option to turn warning on or off ('warnOfUnresolved'). Upped version. * Reverted most eslintrc settings back. * Added yarn.lock * Work on adding function option for variables option. Added unit test, and updated documentation. This is my first pass. * Reordered arguments of getVariableTransformedString, and added the new css test file for testing the variables as function option. * Updated test to test the second argument of the variables function option.
variables
being a function instead of an object