Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing the contents of imported stylesheets #71

Merged
merged 2 commits into from
Mar 30, 2019
Merged

Fix parsing the contents of imported stylesheets #71

merged 2 commits into from
Mar 30, 2019

Conversation

maxmilton
Copy link
Contributor

@maxmilton maxmilton commented Feb 26, 2019

Fixes #70 .

Passes a user defined parser to the processor.process options when running postcss for imported files. This allows for any non-standard syntax to be parsed correctly and added to the resulting AST correctly.

The postcss-import plugin does this in a similar way: https://github.com/postcss/postcss-import/blob/master/lib/process-content.js

This also fixes the following warning when using @import:

You did not set any plugins, parser, or stringifier. Right now, PostCSS does nothing. Pick plugins for your case on https://www.postcss.parts/ and use them in postcss.config.js.

@jonathantneal jonathantneal merged commit 62f14a9 into csstools:master Mar 30, 2019
@jonathantneal
Copy link
Collaborator

This is great, @maxmilton. Thank you

@agconti
Copy link

agconti commented Jan 27, 2020

I'm running into this same problem as well in vercel/next.js#10273.

@jonathantneal Do you plan to release this fix?

@maxmilton
Copy link
Contributor Author

It would be nice to see a release. I've been installing the package from my Github fork for almost a year now 😬

@maxmilton maxmilton mentioned this pull request Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to parse the contents of @import'd files
3 participants