Update chromatic adaptation matrices to higher precision #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
romainmenke
commented
Nov 22, 2023
•
romainmenke
commented
- [css-color-4] Linear Bradford matrices are inexact w3c/csswg-drafts#9607
- Update Oklab matrices for better 64 bit conversion color-js/color.js#357
romainmenke
commented
Nov 22, 2023
| background-image: linear-gradient(rgb(245, 137, 137) 0%, rgb(245, 133, 166), rgb(244, 129, 198), rgb(243, 124, 231), rgb(218, 120, 242), rgb(179, 116, 241), rgb(137, 111, 240), rgb(107, 120, 240), rgb(103, 157, 239), rgb(99, 196, 238), rgb(94, 237, 237) 100%); | ||
| background-image: linear-gradient(rgb(245, 137, 137) 0%, rgb(245, 166, 133), rgb(244, 198, 129), rgb(243, 231, 124), rgb(218, 242, 120), rgb(179, 241, 116), rgb(137, 240, 111), rgb(107, 240, 120), rgb(103, 239, 157), rgb(99, 238, 196), rgb(94, 237, 237) 100%); |
There was a problem hiding this comment.
longer goes around the hue wheel in the different direction because rounding now favors this.
The new output matches Chrome Canary.
(To the best of my knowledge Chrome currently has the best implementation of everything color.)
…er-precision--adaptable-keel-billed-toucan-7f743fdf79
…n--adaptable-keel-billed-toucan-7f743fdf79' of https://github.com/csstools/postcss-plugins into update-chromatic-adaptation-matrices-to-higher-precision--adaptable-keel-billed-toucan-7f743fdf79
Antonio-Laguna
approved these changes
Nov 27, 2023
romainmenke
deleted the
update-chromatic-adaptation-matrices-to-higher-precision--adaptable-keel-billed-toucan-7f743fdf79
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.