update cssdb #1212
Merged
update cssdb #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
Dec 11, 2023
Comment on lines
+3
to
+13
|
|
||
| const variableSpeedCreator = (delay) => { | ||
| return { | ||
| postcssPlugin: `postcss-${delay}ms`, | ||
| Once: async () => { | ||
| await new Promise((resolve) => setTimeout(resolve, delay)); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| variableSpeedCreator.postcss = true; |
There was a problem hiding this comment.
postcss-preset-env is a good case to test the slow plugin detection.
But postcss-preset-env also changes frequently.
We don't want to have to update the test expect files for the slow plugins feature each time postcss-preset-env changes.
Using abstract plugins with an arbitrary delay is also a good way to make sure it works.
romainmenke
deleted the
update-cssdb--persistent-nightingale-c5de62494b
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.